Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies with breaking changes #4555

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

DaniPopes
Copy link
Member

No description provided.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code change

thiserror.workspace = true
sucds = "0.5.0"
sucds = "~0.6"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.7 contains a lot of breaking changes to the API, I'd rather not update this

@@ -68,23 +68,23 @@ sha2 = "0.10.7"
triehash = "0.8"
# See to replace hashers to simplify libraries
plain_hasher = "0.2"
hash-db = "0.15"
hash-db = "~0.15"
Copy link
Member Author

@DaniPopes DaniPopes Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triehash depends on hash-db 0.15

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4555 (77fea5e) into main (7dd14a7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/dns/src/resolver.rs 78.94% <ø> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.74% <ø> (-0.01%) ⬇️
unit-tests 63.99% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.99% <ø> (+0.48%) ⬆️
networking 77.55% <ø> (+<0.01%) ⬆️
rpc 57.37% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.67% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.53% <ø> (+<0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 11, 2023
@mattsse mattsse added this pull request to the merge queue Sep 11, 2023
Merged via the queue into paradigmxyz:main with commit 28f5118 Sep 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants