Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing is empty check #4565

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 12, 2023

No description provided.

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-tx-pool Related to the transaction mempool labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4565 (187b74f) into main (25558b3) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/mod.rs 50.96% <0.00%> (-0.30%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <0.00%> (-0.02%) ⬇️
unit-tests 63.93% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.26% <0.00%> (-0.54%) ⬇️
networking 77.16% <ø> (-0.12%) ⬇️
rpc 57.35% <ø> (-0.01%) ⬇️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.51% <ø> (-0.03%) ⬇️

Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IIUC this path is possible either if all transactions to propagate were EIP-4844 or they were already seen by all peers. We're saving on RwLock::write in these cases.

@mattsse mattsse added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 261a9f9 Sep 12, 2023
24 checks passed
@mattsse mattsse deleted the matt/add-missing-empty-check2 branch September 12, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants