Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rpc): fetch range of blocks and return empty if unchanged #4592

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 13, 2023

not sure if this will fix the bug described in #4590

but I think it does because the range should be inclusive

but this adds a perf improvement: fetch range in one call

return empty if no changes

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Sep 13, 2023
@mattsse mattsse changed the title Matt/perf use range request perf(rpc): fetch range of blocks and return empty if unchanged Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4592 (1ee7f2a) into main (c831d30) will increase coverage by 0.04%.
The diff coverage is 90.90%.

Impacted file tree graph

Files Changed Coverage Δ
crates/storage/provider/src/traits/block_hash.rs 16.66% <ø> (ø)
crates/rpc/rpc/src/eth/filter.rs 62.50% <90.90%> (+2.57%) ⬆️

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.65% <90.90%> (+<0.01%) ⬆️
unit-tests 64.03% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.35% <ø> (+0.02%) ⬆️
trie 94.88% <ø> (ø)
txpool 48.68% <ø> (ø)
networking 77.38% <ø> (+0.15%) ⬆️
rpc 57.42% <90.90%> (+0.05%) ⬆️
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.56% <ø> (+0.02%) ⬆️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 93ccf41 Sep 18, 2023
23 checks passed
@mattsse mattsse deleted the matt/perf-use-range-request branch September 18, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants