Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(txpool): add replacement test #4596

Merged
merged 1 commit into from
Sep 14, 2023
Merged

test(txpool): add replacement test #4596

merged 1 commit into from
Sep 14, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 14, 2023

adds a new test and test helper functions to test replacements in subpools

@mattsse mattsse requested a review from rkrasiuk September 14, 2023 10:42
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Sep 14, 2023
@mattsse mattsse requested a review from Rjected September 14, 2023 10:43
@mattsse mattsse added the C-test A change that impacts how or what we test label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #4596 (078dcde) into main (09b5f10) will increase coverage by 0.06%.
The diff coverage is 86.79%.

Impacted file tree graph

Files Changed Coverage Δ
crates/transaction-pool/src/pool/pending.rs 83.26% <0.00%> (-1.09%) ⬇️
crates/transaction-pool/src/pool/mod.rs 51.52% <80.00%> (+0.55%) ⬆️
crates/transaction-pool/src/pool/txpool.rs 71.84% <94.11%> (+1.39%) ⬆️
crates/transaction-pool/src/pool/parked.rs 80.00% <100.00%> (+0.32%) ⬆️
crates/transaction-pool/src/traits.rs 12.55% <100.00%> (+1.07%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.62% <1.88%> (-0.02%) ⬇️
unit-tests 64.05% <86.79%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.53% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 49.26% <86.79%> (+0.57%) ⬆️
networking 77.38% <ø> (+0.19%) ⬆️
rpc 57.35% <ø> (ø)
consensus 63.40% <ø> (ø)
revm 31.56% <ø> (ø)
payload builder 6.12% <ø> (ø)
primitives 86.53% <ø> (ø)

@mattsse mattsse requested a review from shekhirin September 14, 2023 10:51
@mattsse mattsse force-pushed the matt/add-additional-replacement-test branch from 3fd6f27 to 9bc9447 Compare September 14, 2023 10:53
@mattsse mattsse force-pushed the matt/add-additional-replacement-test branch from 9bc9447 to 078dcde Compare September 14, 2023 11:17
@mattsse mattsse added this pull request to the merge queue Sep 14, 2023
@mattsse mattsse mentioned this pull request Sep 14, 2023
Merged
rkrasiuk
rkrasiuk approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse removed this pull request from the merge queue due to a manual request Sep 14, 2023
@mattsse mattsse added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 723036b Sep 14, 2023
@mattsse mattsse deleted the matt/add-additional-replacement-test branch September 14, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @shekhirin @rkrasiuk