-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitives): add Receipts
to encapsulate Vec<Vec<Option<Receipt>>
#4626
Conversation
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit
crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs
Outdated
Show resolved
Hide resolved
Just one more code blocks that can be moved to a function inside reth/crates/revm/src/processor.rs Lines 329 to 347 in 8baf234
|
@rakita Done |
crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending @rakita
and conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a request for change here: #4626 (comment)
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@tcoratger there is one conflict at crates/payload/basic/src/lib.rs |
Head branch was pushed to by a user without write access
@rakita Just solved :) |
Should resolve #4621.