Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4844 blob txs #4631

Merged
merged 3 commits into from
Sep 18, 2023
Merged

4844 blob txs #4631

merged 3 commits into from
Sep 18, 2023

Conversation

supernovahs
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 17, 2023 •
edited
Loading

Codecov Report

Merging #4631 (ceb0d1e) into main (a55f48c) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/call.rs 58.88% <ø> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 30.76% <0.00%> (-0.12%) ⬇️
crates/rpc/rpc/src/eth/revm_utils.rs 38.08% <100.00%> (+0.18%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.98% <66.66%> (-0.02%) ⬇️
unit-tests 63.16% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 31.37% <ø> (ø)
blockchain tree 83.59% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.44% <ø> (ø)
trie 94.70% <ø> (-0.04%) ⬇️
txpool 49.16% <ø> (-0.49%) ⬇️
networking 77.20% <ø> (-0.06%) ⬇️
rpc 57.33% <66.66%> (-0.13%) ⬇️
consensus 62.42% <ø> (ø)
revm 19.67% <ø> (ø)
payload builder 9.06% <ø> (ø)
primitives 86.42% <ø> (-0.04%) ⬇️

mattsse
mattsse approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

added a serde default, for the vec

@mattsse mattsse enabled auto-merge September 18, 2023 08:24
@mattsse mattsse added this pull request to the merge queue Sep 18, 2023
Merged via the queue into paradigmxyz:main with commit 16072b9 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supernovahs @mattsse