Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of unreachable #4638

Merged
merged 1 commit into from
Sep 18, 2023
Merged

chore: get rid of unreachable #4638

merged 1 commit into from
Sep 18, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 18, 2023

bump revm and get rid of unreachable match arm

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4638 (f5de373) into main (93ccf41) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc/src/eth/error.rs 9.55% <ø> (+0.05%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.00% <ø> (-0.02%) ⬇️
unit-tests 63.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 31.95% <ø> (ø)
blockchain tree 83.59% <ø> (ø)
pipeline 88.54% <ø> (ø)
storage (db) 73.47% <ø> (ø)
trie 94.73% <ø> (+0.03%) ⬆️
txpool 49.42% <ø> (ø)
networking 77.18% <ø> (-0.11%) ⬇️
rpc 57.40% <ø> (-0.02%) ⬇️
consensus 62.42% <ø> (ø)
revm 19.66% <ø> (ø)
payload builder 9.06% <ø> (ø)
primitives 86.45% <ø> (+0.02%) ⬆️

@Rjected Rjected added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 69045fd Sep 18, 2023
23 checks passed
@Rjected Rjected deleted the matt/replace-unreachable branch September 18, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants