Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interfaces): move BlockHashNotFoundInChain to BlockchainTreeError #4697

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

tcoratger
Copy link
Contributor

In this PR, the BlockHashNotFoundInChain is completely removed from the BlockExecutionError enum and it is moved to BlockchainTreeError (enum in which this error already existed).

Necessary adjustments are made, consisting of integrating BlockchainTreeError errors into the RethError enum in order to satisfy the conditions previously met by the implementation of BlockHashNotFoundInChain inside BlockExecutionError.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4697 (2282c2d) into main (a52b433) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 74.25% <0.00%> (ø)
crates/interfaces/src/blockchain_tree/error.rs 36.29% <0.00%> (-0.60%) ⬇️
crates/interfaces/src/error.rs 100.00% <ø> (ø)
crates/interfaces/src/executor.rs 40.00% <ø> (ø)

... and 4 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <0.00%> (-0.01%) ⬇️
unit-tests 63.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.51% <ø> (ø)
trie 94.73% <ø> (ø)
txpool 49.44% <ø> (ø)
networking 77.10% <ø> (ø)
rpc 57.81% <ø> (-0.01%) ⬇️
consensus 63.21% <0.00%> (ø)
revm 28.24% <ø> (ø)
payload builder 8.45% <ø> (ø)
primitives 86.53% <0.00%> (-0.03%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mattsse mattsse added this pull request to the merge queue Sep 21, 2023
Merged via the queue into paradigmxyz:main with commit 6d3e229 Sep 21, 2023
22 checks passed
@tcoratger tcoratger deleted the BlockHashNotFoundInChain branch September 21, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants