Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Add enode address on startup #4712

Merged
merged 1 commit into from
Sep 21, 2023
Merged

(chore) Add enode address on startup #4712

merged 1 commit into from
Sep 21, 2023

Conversation

0xprames
Copy link
Contributor

this should fix #4698

geth logs the enodeon p2p server start

i've added it when reth node logs that it has successfully connected to the p2p network

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #4712 (b0ff4d6) into main (5c3d7d0) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/node/mod.rs 26.11% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <0.00%> (-0.02%) ⬇️
unit-tests 63.31% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <0.00%> (ø)
blockchain tree 83.75% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.52% <ø> (ø)
trie 94.73% <ø> (ø)
txpool 49.82% <ø> (-0.49%) ⬇️
networking 77.11% <ø> (-0.07%) ⬇️
rpc 57.85% <ø> (+0.01%) ⬆️
consensus 63.09% <ø> (ø)
revm 28.38% <ø> (ø)
payload builder 8.35% <ø> (ø)
primitives 86.54% <ø> (-0.01%) ⬇️

mattsse
mattsse approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Sep 21, 2023
@mattsse mattsse added A-observability Related to tracing, metrics, logs and other observability tools A-cli Related to the reth CLI labels Sep 21, 2023
Merged via the queue into paradigmxyz:main with commit 9c51a0a Sep 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show enode address on startup
2 participants
@0xprames @mattsse