Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): implement PropagateHashTo helper in TransactionsCommand #4713

Merged
merged 4 commits into from
Sep 26, 2023
Merged

feat(network): implement PropagateHashTo helper in TransactionsCommand #4713

merged 4 commits into from
Sep 26, 2023

Conversation

duguorong009
Copy link
Contributor

@duguorong009 duguorong009 commented Sep 21, 2023 •
edited
Loading

Related issues

Changes

  • add the implementation of propagate_hash_to for TransactionsCommand helper

@duguorong009 duguorong009 marked this pull request as draft September 21, 2023 14:44
@duguorong009 duguorong009 mentioned this pull request Sep 21, 2023
Closed
mattsse
mattsse requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start

crates/net/network/src/transactions.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request A-networking Related to networking in general labels Sep 21, 2023
mattsse
mattsse requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

crates/net/network/src/transactions.rs Outdated Show resolved Hide resolved
crates/net/network/src/transactions.rs Outdated Show resolved Hide resolved
@duguorong009 duguorong009 marked this pull request as ready for review September 23, 2023 09:23
mattsse
mattsse approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

I only made some smol changes

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #4713 (d6aafe7) into main (a29f102) will decrease coverage by 0.05%.
Report is 45 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/net/network/src/transactions.rs 56.76% <0.00%> (-3.24%) ⬇️

... and 113 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.50% <0.00%> (-0.24%) ⬇️
unit-tests 63.36% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.23% <ø> (+0.06%) ⬆️
blockchain tree 83.69% <ø> (-0.07%) ⬇️
pipeline 88.53% <ø> (ø)
storage (db) 73.49% <ø> (+0.97%) ⬆️
trie 94.48% <ø> (-0.29%) ⬇️
txpool 49.51% <ø> (-0.32%) ⬇️
networking 76.66% <0.00%> (-0.50%) ⬇️
rpc 57.67% <ø> (-0.18%) ⬇️
consensus 62.84% <ø> (-0.38%) ⬇️
revm 28.33% <ø> (-0.06%) ⬇️
payload builder 8.20% <ø> (-0.25%) ⬇️
primitives 86.49% <ø> (-0.07%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 26, 2023
Merged via the queue into paradigmxyz:main with commit 321ded5 Sep 26, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duguorong009 @mattsse