-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: Manual P2P #4736
Example: Manual P2P #4736
Conversation
Codecov Report
see 114 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is cool. no objections. thank you for taking this on! curious if you have any api feedback improvement ideas?
find peer via discv4 -> p2p handshake -> eth handshake -> listen to msgs
maybe @mattsse has thoughts on API improvements so holding off on merging
Don't have any immediate feedback, setting up each layer was clear + intuitive enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last style nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tysm for this
Example of peer communication using low level components from the net crate.