-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support trace_filter #4818
Conversation
b0fe3d7
to
a68bb3b
Compare
a68bb3b
to
12d5cf2
Compare
Codecov Report
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is great. I need to sync my node and then I'll start testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, looks like this is good enough for testing
Adds limited support for #4799
This currently enforces a block range and caps at 100 blocks (can be extended after some testing)
There is some room for perf improvements, like only tracing up until the highest relevant tx in a matching block. But let's check perf first.
FYI @tjayrush