fix(bin): latest block in status message #4856
Conversation
shekhirin
added
A-observability
shekhirin
force-pushed
the
alexey/status-latest-block
branch
from
da6e1fd to
6f9d0a7
Compare
bin/reth/src/node/events.rs
Outdated
| @@ -79,6 +79,7 @@ impl NodeState { | |||
| result: ExecOutput { checkpoint, done }, | |||
| } => { | |||
| self.current_checkpoint = checkpoint; | |||
| self.latest_block = Some(checkpoint.block_number); | |||
There was a problem hiding this comment.
hmm, I'm skeptical that this is the correct fix, because we only want to do this for the finish stage but this updates it for every stage, right?
There was a problem hiding this comment.
hmm, you're right, added a check for Finish stage
Codecov Report
... and 12 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bin/reth/src/node/events.rs
Outdated
| @@ -124,7 +127,7 @@ impl NodeState { | |||
| ); | |||
| } | |||
| BeaconConsensusEngineEvent::CanonicalBlockAdded(block) => { | |||
| self.latest_canonical_engine_block = Some(block.number); | |||
| self.latest_block = Some(block.number); | |||
There was a problem hiding this comment.
I think this needs to be moved to the CanonicalChainCommitted event ?
There was a problem hiding this comment.
makes sense, CanonicalBlockAdded is called on new payloads
Ref #4854 (comment)
Report latest block in
Statusmessage as the latest reached by either pipeline or blockchain tree.