feat: add discv4 terminate #4879
Conversation
DoTheBestToGetTheBest
requested review from
mattsse and
Rjected
as code owners
|
Could i ask help on what i need to do in the next step please? |
Codecov Report
... and 13 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
crates/net/discv4/src/lib.rs
Outdated
| node.value.has_endpoint_proof | ||
| && !self.pending_find_nodes.contains_key(&node.key.preimage().0) |
There was a problem hiding this comment.
please use nightly formatting cargo +nightly fmt
crates/net/discv4/src/lib.rs
Outdated
| //self.terminate(); | ||
| todo!() |
There was a problem hiding this comment.
this needs to emit the event
and here we need to handle the terminate by returning None if event is terminate
reth/crates/net/discv4/src/lib.rs
Line 1618 in 858ea41
There was a problem hiding this comment.
this needs to emit the event
I'm really sorry but i don't understand what do you means by it need to emit the events, could you explain me this please?
|
I'm really sorry if i'm asking newbie questions for most of you |
|
it's okay, we're almost there, the only thing missing: |
I'm really sorry but i didn't what it means by emit the event ? Sorry again Mat, i know you have better to do then telling me |
|
@mattsse hey again, sorry again for all this questions. How it look like for you ? added an event, and return None if Poll::ready is terminated |
oh i don't understand this, is this okey ? or i need to change others thing or i'm wrong in the implementation ? Don't tell me thank you please, i'am the one who tell you thank you so much. You're spending time to explain me thing and also giving me chance to participate on good issue. Thank you so much. I'm exicted to take my other issue |
Everything good then Matt thank you so much, i'm ready to take another good first issue if you can open one please :) |
mattsse
added
C-enhancement
|
I take another good first issue if you open one today :) |
Draft for #4874