Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dedicated send functions #4903

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore: add dedicated send functions #4903

merged 1 commit into from
Oct 4, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 4, 2023

prep for #4902

clean up some notify code for better reuse

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-tx-pool Related to the transaction mempool labels Oct 4, 2023
@mattsse mattsse requested a review from rkrasiuk October 4, 2023 13:39
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #4903 (c992e25) into main (afebb2b) will decrease coverage by 0.03%.
The diff coverage is 48.64%.

Impacted file tree graph

Files Coverage Δ
crates/transaction-pool/src/pool/mod.rs 50.53% <48.64%> (+2.14%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.51% <48.64%> (+0.01%) ⬆️
unit-tests 62.64% <21.62%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.58% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.32% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 49.11% <48.64%> (-0.25%) ⬇️
networking 76.07% <ø> (-0.03%) ⬇️
rpc 57.74% <ø> (-0.01%) ⬇️
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.41% <ø> (-0.04%) ⬇️

@mattsse mattsse added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 5f56e52 Oct 4, 2023
23 checks passed
@mattsse mattsse deleted the matt/cleanup-notifications branch October 4, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk