Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ipc path to config #4920

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: add ipc path to config #4920

merged 2 commits into from
Oct 5, 2023
+19 −5

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 5, 2023

smol addition

@mattsse mattsse added A-rpc Related to the RPC implementation A-cli Related to the reth CLI labels Oct 5, 2023
Rjected
Rjected approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like this needs merge conflicts to be resolved and Clone added to GasPriceOracleConfig

@mattsse mattsse enabled auto-merge October 5, 2023 18:59
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #4920 (c5f6979) into main (a9b09a7) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

Files Coverage Δ
bin/reth/src/args/gas_price_oracle_args.rs 100.00% <100.00%> (ø)
bin/reth/src/cli/config.rs 0.00% <ø> (ø)
bin/reth/src/args/rpc_server_args.rs 57.77% <25.00%> (-0.46%) ⬇️
crates/rpc/rpc-builder/src/auth.rs 44.44% <0.00%> (-0.66%) ⬇️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.49% <0.00%> (-0.02%) ⬇️
unit-tests 62.74% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 33.00% <40.00%> (-0.02%) ⬇️
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.43% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 48.89% <ø> (-0.49%) ⬇️
networking 76.06% <ø> (-0.07%) ⬇️
rpc 57.66% <0.00%> (-0.01%) ⬇️
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.15% <ø> (ø)
primitives 85.39% <ø> (-0.01%) ⬇️

@mattsse mattsse added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 12c0bde Oct 5, 2023
23 checks passed
@mattsse mattsse deleted the matt/some-rpc-touchups branch October 5, 2023 19:20
mattsse added a commit that referenced this pull request Nov 8, 2023
@mattsse
feat: add ipc path to config (#4920)
ccf792e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected