fix(engine): always push back hooks, add tests

[shekhirin]

Problem

We didn't push hook back to the collection in two cases:

1. When it's a read-write hook and we can't poll it because another read-write hook is running:

   reth/crates/consensus/beacon/src/engine/hooks/controller.rs

   Lines 106 to 110 in 760a515

   	if hook.db_access_level().is_read_write() &&
   	(self.running_hook_with_db_write.is_some() || db_write_active)
   	{
   	return Poll::Pending
   	}

2. When hook.poll returns an error, and we short-circuit with ?:

   reth/crates/consensus/beacon/src/engine/hooks/controller.rs

   Line 112 in 760a515

   if let Poll::Ready((event, action)) = hook.poll(cx, args)? {

Solution

This PR introduces a helper poll_next_hook_inner method which guarantees that after trying to poll the hook we will either set the read-write hook as running, or push the hook back into collection.

Also, I covered the functionality of both poll_running_hook_with_db_write and poll_next_hook with tests of various scenarios.

[codecov]

Codecov Report

Merging #4924 (d0b4456) into main (1e7d028) will increase coverage by 0.25%.
Report is 2 commits behind head on main.
The diff coverage is 99.48%.

Files	Coverage Δ
...es/consensus/beacon/src/engine/hooks/controller.rs	95.70% <100.00%> (+16.29%)	⬆️
crates/consensus/beacon/src/engine/hooks/mod.rs	66.66% <0.00%> (+11.11%)	⬆️

... and 31 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	15.47% <0.00%> (-0.01%)	⬇️
unit-tests	62.90% <99.48%> (+0.25%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	33.02% <ø> (+0.07%)	⬆️
blockchain tree	80.63% <ø> (+0.08%)	⬆️
pipeline	88.45% <ø> (+<0.01%)	⬆️
storage (db)	74.43% <ø> (+1.14%)	⬆️
trie	94.48% <ø> (ø)
txpool	48.89% <ø> (-0.50%)	⬇️
networking	76.09% <ø> (-0.04%)	⬇️
rpc	57.71% <ø> (+<0.01%)	⬆️
consensus	63.01% <99.48%> (+2.16%)	⬆️
revm	28.47% <ø> (ø)
payload builder	8.14% <ø> (ø)
primitives	85.42% <ø> (+0.04%)	⬆️

[mattsse]

lgtm