Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(payload): additional debug logs #4926

Merged
merged 2 commits into from
Oct 5, 2023
Merged

chore(payload): additional debug logs #4926

merged 2 commits into from
Oct 5, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Oct 5, 2023

Description

Additional debug logs for the default payload builder.

@rkrasiuk rkrasiuk added A-block-building Related to block building A-observability Related to tracing, metrics, logs and other observability tools labels Oct 5, 2023
mattsse
mattsse requested changes Oct 5, 2023
View reviewed changes
crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
crates/payload/basic/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #4926 (92fb570) into main (066998d) will increase coverage by 0.09%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/payload/basic/src/lib.rs 0.00% <0.00%> (ø)

... and 36 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.50% <0.00%> (+<0.01%) ⬆️
unit-tests 62.74% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 33.02% <ø> (+0.38%) ⬆️
blockchain tree 80.63% <ø> (-0.01%) ⬇️
pipeline 88.45% <ø> (+<0.01%) ⬆️
storage (db) 74.43% <ø> (+1.13%) ⬆️
trie 94.48% <ø> (ø)
txpool 48.89% <ø> (-0.21%) ⬇️
networking 76.08% <ø> (-0.06%) ⬇️
rpc 57.67% <ø> (-0.05%) ⬇️
consensus 61.05% <ø> (ø)
revm 28.47% <ø> (ø)
payload builder 8.15% <0.00%> (-0.02%) ⬇️
primitives 85.38% <ø> (-0.06%) ⬇️

@rkrasiuk rkrasiuk requested a review from mattsse October 5, 2023 19:03
@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit ec543ab Oct 5, 2023
23 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/payload-building-logs branch October 5, 2023 19:52
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@rkrasiuk @mattsse
chore(payload): additional debug logs (#4926)
8f3e7cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse