Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify full transaction listeners (4902) #4978

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

SleepingShell
Copy link
Contributor

Please see #4902 for discussion.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4978 (e0cbbec) into main (1cccd09) will increase coverage by 0.11%.
Report is 12 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc/src/eth/pubsub.rs 6.66% <ø> (ø)
crates/transaction-pool/src/pool/mod.rs 48.22% <0.00%> (-2.14%) ⬇️

... and 39 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.41% <0.00%> (+0.13%) ⬆️
unit-tests 62.52% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.62% <ø> (-0.14%) ⬇️
blockchain tree 80.64% <ø> (+0.01%) ⬆️
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <ø> (-0.01%) ⬇️
trie 94.48% <ø> (-0.04%) ⬇️
txpool 48.30% <0.00%> (-0.23%) ⬇️
networking 76.09% <ø> (-0.07%) ⬇️
rpc 57.95% <ø> (-0.11%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.35% <ø> (+0.90%) ⬆️

@rkrasiuk rkrasiuk added the A-tx-pool Related to the transaction mempool label Oct 11, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is very clean

@mattsse mattsse enabled auto-merge October 12, 2023 11:13
@mattsse mattsse added this pull request to the merge queue Oct 12, 2023
Merged via the queue into paradigmxyz:main with commit bd7b8f5 Oct 12, 2023
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants