Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add debug trace ext helpers #4982

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 11, 2023

Adds a helper function to debug trace block errors: #4951

also includes a deserialization fix for Block and a helper fn to iterate over tx hashes

@mattsse mattsse requested a review from Rjected as a code owner October 11, 2023 13:54
@mattsse mattsse added A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #4982 (3fef96a) into main (00a92f5) will decrease coverage by 0.03%.
The diff coverage is 32.65%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-testing-util/src/trace.rs 40.42% <ø> (ø)
crates/rpc/rpc-types/src/eth/block.rs 65.98% <62.74%> (+6.91%) ⬆️
crates/rpc/rpc-testing-util/src/debug.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.41% <0.00%> (-0.03%) ⬇️
unit-tests 62.48% <32.65%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.63% <ø> (ø)
blockchain tree 80.64% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.52% <ø> (+0.03%) ⬆️
txpool 48.52% <ø> (ø)
networking 76.10% <ø> (-0.03%) ⬇️
rpc 57.95% <32.65%> (-0.10%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.37% <ø> (ø)

@mattsse mattsse added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit b076a01 Oct 11, 2023
23 checks passed
@mattsse mattsse deleted the matt/add-trace-helpers branch October 11, 2023 14:59
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants