Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EthTransactionValidator::validate_all function #5006

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

close #5001

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Oct 12, 2023
@DoTheBestToGetTheBest
Copy link
Contributor Author

great

Thank you , really happy to participate on all this. Please don't hesitate to open more issue i take as much as i can :) Thank you so much for all your work @mattsse !

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5006 (edfbdd5) into main (e86b80a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/transaction-pool/src/validate/eth.rs 7.37% <0.00%> (-0.12%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.85% <0.00%> (-0.01%) ⬇️
unit-tests 62.37% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.93% <ø> (ø)
blockchain tree 80.81% <ø> (ø)
pipeline 88.37% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 48.60% <0.00%> (+0.39%) ⬆️
networking 76.45% <ø> (-0.02%) ⬇️
rpc 57.98% <ø> (-0.01%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.89% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.24% <ø> (+<0.01%) ⬆️

@mattsse mattsse added this pull request to the merge queue Oct 12, 2023
Merged via the queue into paradigmxyz:main with commit 34bc498 Oct 12, 2023
23 checks passed
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EthTransactionValidator::validate_all function
2 participants