Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): move mev types to rpc-types #5035

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

tcoratger
Copy link
Contributor

Should close #5030.

This PR only contains the porting of mev types, we can surely open an issue regarding the migration to alloy rather than ethers_core.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #5035 (b54ea97) into main (411893e) will increase coverage by 0.86%.
Report is 11 commits behind head on main.
The diff coverage is 77.72%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/serde_helper/mod.rs 63.88% <ø> (ø)
crates/rpc/rpc-types/src/mev.rs 77.72% <77.72%> (ø)

... and 39 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.03% <0.00%> (+1.19%) ⬆️
unit-tests 62.24% <77.72%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.41% <ø> (+0.04%) ⬆️
storage (db) 74.43% <ø> (+0.03%) ⬆️
trie 94.48% <ø> (ø)
txpool 54.78% <ø> (+6.85%) ⬆️
networking 78.16% <ø> (+1.72%) ⬆️
rpc 58.46% <77.72%> (+0.56%) ⬆️
consensus 63.01% <ø> (ø)
revm 28.00% <ø> (+0.11%) ⬆️
payload builder 7.96% <ø> (ø)
primitives 86.53% <ø> (+0.50%) ⬆️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I migrated to reth_primitives types

@mattsse mattsse added this pull request to the merge queue Oct 16, 2023
Merged via the queue into paradigmxyz:main with commit 9ffc143 Oct 16, 2023
23 checks passed
@tcoratger tcoratger deleted the mev-types branch October 17, 2023 17:45
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move types to rpc-types crate
2 participants