Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: move common_prefix_len out of loop #5036

Merged
merged 1 commit into from
Oct 16, 2023
Merged

perf: move common_prefix_len out of loop #5036

merged 1 commit into from
Oct 16, 2023

Conversation

robinsdan
Copy link
Contributor

This current key will never shrink to a length less than common_prefix_len within the loop.

@robinsdan robinsdan requested a review from gakonst as a code owner October 16, 2023 09:37
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #5036 (101fb20) into main (a60dbfd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

Files Coverage Δ
crates/primitives/src/trie/hash_builder/mod.rs 86.91% <100.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.12% <100.00%> (-0.01%) ⬇️
unit-tests 62.19% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.37% <ø> (ø)
storage (db) 74.43% <ø> (ø)
trie 94.48% <ø> (ø)
txpool 55.22% <ø> (+0.43%) ⬆️
networking 78.19% <ø> (+0.02%) ⬆️
rpc 57.81% <ø> (+<0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 28.00% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.54% <100.00%> (-0.02%) ⬇️

@rkrasiuk rkrasiuk added C-debt A clean up/refactor of existing code A-trie Related to Merkle Patricia Trie implementation labels Oct 16, 2023
@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 16, 2023
Merged via the queue into paradigmxyz:main with commit cd67eac Oct 16, 2023
@robinsdan robinsdan deleted the prefix branch October 16, 2023 10:40
rkrasiuk added a commit that referenced this pull request Oct 16, 2023
@rkrasiuk
Revert "perf: move common_prefix_len out of loop (#5036)"
a1339db 
This reverts commit cd67eac.
@rkrasiuk rkrasiuk mentioned this pull request Oct 16, 2023
Merged
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@robinsdan @mattsse
perf: move common_prefix_len out of loop (#5036)
79dc903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinsdan @rkrasiuk