chore(txpool): use Vec in validate_all #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
changed the title
Rjected
changed the title
Codecov Report
... and 35 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
requested changes
Oct 17, 2023
crates/transaction-pool/src/lib.rs
Outdated
Comment on lines
239
to
242
| for tx in transactions.into_iter() { | ||
| let validate_outcome = self.validate(origin, tx).await; | ||
| outcomes.push(validate_outcome); | ||
| } |
There was a problem hiding this comment.
this is not equivalent because now all futures are polled one by one
this should just collect into a vec instead
There was a problem hiding this comment.
right, forgot that join_all would be better and preserves input order
mattsse
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a
Vecinvalidate_allso the order can be preserved. The transactions are now validated in the order they are inserted