refactor(trie): trie node iterators #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-debt
rkrasiuk
commented
Oct 17, 2023
Comment on lines
+20
to
22
| // TODO: remove in the next breaking release. | ||
| /// The last walker key processed. | ||
| pub last_walker_key: Vec<u8>, |
There was a problem hiding this comment.
Nothing i can do here atm without breaking the format, will open a separate PR for this
rkrasiuk
commented
Oct 17, 2023
rkrasiuk
commented
Oct 17, 2023
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Oct 17, 2023
| #[derive(Debug)] | ||
| pub struct TrieWalker<'a, K, C> { | ||
| pub struct TrieWalker<C> { |
There was a problem hiding this comment.
this looks indeed simpler
|
@mattsse the main refactor is creating these iterators https://github.com/paradigmxyz/reth/blob/7a080f7a3d2941feed5cb074ee529374ae983af2/crates/trie/src/node_iter.rs |
rkrasiuk
force-pushed
the
rkrasiuk/trie-node-iter
branch
from
7a080f7
to
81fede3
Compare
rkrasiuk
force-pushed
the
rkrasiuk/trie-node-iter
branch
from
81fede3
to
b83dc81
Compare
|
tested on sepolia ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor common iteration steps into
AccountNodeIterandStorageNodeIteriterators, get rid of redundant generics.Summary
🤖 Generated by Copilot at b424fb4
This pull request refactors the state root and storage root calculation logic in the
rethcrate, using new iterator-based abstractions and moving some types and functions to theprimitivescrate. It also simplifies the code, fixes a bug in the proof generation, and adds a new dependency on theauto_implcrate. The affected files are mostly in thetriecrate, but also in thestagesandprimitivescrates.