chore(revm): remove local thread for pipeline execution stage #5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
added
C-debt
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rkrasiuk
approved these changes
Oct 19, 2023
| .expect("Expects that thread name is not null"); | ||
| handle.join().expect("Expects for thread to not panic") | ||
| }) | ||
| self.execute_inner(provider, input) |
There was a problem hiding this comment.
seems like we can merge execute & execute_inner now
mattsse
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revm requirements for stack were decremented here: bluealloy/revm#712
So a resized bigger stack is not needed.
This PR removes the resized local thread from the code.