Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): eip-1159 -> eip-1559 #5083

Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore(rpc): eip-1159 -> eip-1559 #5083

merged 1 commit into from
Oct 19, 2023

Conversation

itsdevbear
Copy link
Contributor

@itsdevbear itsdevbear commented Oct 19, 2023 •
edited
Loading

Just a simple fix.

Rjected
Rjected approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #5083 (a3c555c) into main (3adc627) will decrease coverage by 0.05%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-api/src/eth.rs 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.06% <ø> (-0.03%) ⬇️
unit-tests 62.37% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.90% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.38% <ø> (ø)
storage (db) 74.64% <ø> (ø)
trie 94.96% <ø> (ø)
txpool 55.33% <ø> (ø)
networking 78.20% <ø> (-0.06%) ⬇️
rpc 58.31% <ø> (-0.19%) ⬇️
consensus 63.01% <ø> (ø)
revm 28.73% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 86.42% <ø> (ø)

@Rjected Rjected added this pull request to the merge queue Oct 19, 2023
Merged via the queue into paradigmxyz:main with commit 7ca3db8 Oct 19, 2023
23 checks passed
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@itsdevbear @mattsse
chore(rpc): eip-1159 -> eip-1559 (#5083)
a7dc828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsdevbear @Rjected