clean up database file after testing #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinsdan
requested review from
onbjerg,
rkrasiuk,
shekhirin and
gakonst
as code owners
mattsse
requested changes
Oct 19, 2023
| /// Create read/write database for testing | ||
| pub fn create_test_rw_db() -> Arc<DatabaseEnv> { | ||
| Arc::new( |
There was a problem hiding this comment.
I see, since we consumed the tempdir it never got cleaned up on drop
mattsse
requested changes
Oct 19, 2023
crates/storage/db/src/lib.rs
Outdated
| @@ -171,26 +172,76 @@ pub mod test_utils { | |||
| /// Error during tempdir creation | |||
| pub const ERROR_TEMPDIR: &str = "Not able to create a temporary directory."; | |||
|
|
|||
| /// A database will delete the db dir when dropped. | |||
| #[derive(Debug)] | |||
| pub struct TestTempDatabase<DB> { | |||
There was a problem hiding this comment.
let's rename this To TempDatabase instead
Codecov Report
... and 415 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
bump @joshieDo |
joshieDo
reviewed
Oct 24, 2023
joshieDo
reviewed
Oct 24, 2023
joshieDo
approved these changes
Oct 24, 2023
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Arindam2407
pushed a commit
to Arindam2407/reth
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
mattsse
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time the test is executed, it occupies 4GB of disk space, quickly depleting my disk.