Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc): remove result_output from revm_utils #5097

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

tcoratger
Copy link
Contributor

Should close #5096.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5097 (e44bb29) into main (05044c1) will decrease coverage by 0.06%.
Report is 9 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc/src/eth/revm_utils.rs 45.54% <ø> (+0.64%) ⬆️
crates/rpc/rpc/src/debug.rs 6.79% <0.00%> (ø)

... and 38 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.06% <0.00%> (-0.01%) ⬇️
unit-tests 62.34% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (-0.05%) ⬇️
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (-0.02%) ⬇️
storage (db) 74.64% <ø> (+<0.01%) ⬆️
trie 94.96% <ø> (ø)
txpool 55.76% <ø> (+0.43%) ⬆️
networking 78.16% <ø> (-0.22%) ⬇️
rpc 58.41% <0.00%> (+0.10%) ⬆️
consensus 63.01% <ø> (ø)
revm 28.73% <ø> (+<0.01%) ⬆️
payload builder 7.95% <ø> (ø)
primitives 85.88% <ø> (-0.57%) ⬇️

@mattsse mattsse added this pull request to the merge queue Oct 19, 2023
Merged via the queue into paradigmxyz:main with commit a136c33 Oct 19, 2023
23 checks passed
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(rpc): remove result_output from revm_utils
2 participants