Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function builder for TransacitonRequest #5104

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Function builder for TransacitonRequest #5104

merged 3 commits into from
Oct 22, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #5104 (3bab6c8) into main (5dd5555) will decrease coverage by 0.17%.
Report is 13 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
...rates/rpc/rpc-types/src/eth/transaction/request.rs 1.19% <0.00%> (-0.90%) ⬇️

... and 49 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.07% <0.00%> (-0.02%) ⬇️
unit-tests 62.14% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.60% <ø> (-0.05%) ⬇️
trie 94.96% <ø> (-0.04%) ⬇️
txpool 55.33% <ø> (ø)
networking 78.18% <ø> (ø)
rpc 57.80% <0.00%> (-0.67%) ⬇️
consensus 63.01% <ø> (ø)
revm 24.47% <ø> (-4.27%) ⬇️
payload builder 7.95% <ø> (ø)
primitives 84.71% <ø> (-1.17%) ⬇️

mattsse
mattsse requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

only cosmetic nits

crates/rpc/rpc-types/src/eth/transaction/request.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/transaction/request.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types/src/eth/transaction/request.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

nice,

only cosmetic nits

Thank you so so so much !

@mattsse mattsse enabled auto-merge October 22, 2023 08:55
@mattsse mattsse added this pull request to the merge queue Oct 22, 2023
Merged via the queue into paradigmxyz:main with commit c74abbc Oct 22, 2023
mattsse added a commit that referenced this pull request Nov 8, 2023
@DoTheBestToGetTheBest @mattsse
Function builder for TransacitonRequest (#5104)
c2c6972 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoTheBestToGetTheBest @mattsse