Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Patch revm to current head commit #5109

Merged
merged 9 commits into from
Oct 20, 2023
Merged

chore: Patch revm to current head commit #5109

merged 9 commits into from
Oct 20, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 20, 2023

based on #5032

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #5109 (3e48a91) into main (fafcabf) will decrease coverage by 0.02%.
The diff coverage is 3.79%.

Impacted file tree graph

Files Coverage Δ
crates/revm/revm-inspectors/src/access_list.rs 45.28% <100.00%> (-4.72%) ⬇️
...es/revm/revm-inspectors/src/tracing/js/bindings.rs 16.52% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/opcount.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/call.rs 48.65% <50.00%> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 33.49% <0.00%> (ø)
crates/rpc/rpc/src/eth/revm_utils.rs 45.54% <0.00%> (ø)
...es/revm/revm-inspectors/src/tracing/js/builtins.rs 13.73% <0.00%> (+0.22%) ⬆️
crates/revm/revm-inspectors/src/tracing/utils.rs 0.00% <0.00%> (ø)
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
... and 9 more

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.08% <3.79%> (+0.01%) ⬆️
unit-tests 62.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.60% <ø> (ø)
trie 95.00% <ø> (+0.03%) ⬆️
txpool 55.33% <ø> (-0.45%) ⬇️
networking 78.19% <ø> (-0.01%) ⬇️
rpc 57.97% <10.00%> (-0.03%) ⬇️
consensus 63.01% <ø> (ø)
revm 24.54% <3.38%> (+0.35%) ⬆️
payload builder 7.95% <0.00%> (ø)
primitives 84.74% <ø> (-0.11%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rkrasiuk rkrasiuk added the A-dependencies Pull requests or issues that are about dependencies label Oct 20, 2023
@mattsse mattsse requested a review from rakita October 20, 2023 14:55
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 14f2b90 Oct 20, 2023
24 checks passed
@Rjected Rjected deleted the cl/upgrade-revm branch October 20, 2023 19:19
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: clabby <ben@clab.by>
Co-authored-by: rakita <dragan0rakita@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants