Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove reth primitives [tokio] and [tokio-stream] dependencies #5111

Merged
merged 7 commits into from
Oct 21, 2023
Merged

chore: remove reth primitives [tokio] and [tokio-stream] dependencies #5111

merged 7 commits into from
Oct 21, 2023

Conversation

gr4yha7
Copy link
Contributor

@gr4yha7 gr4yha7 commented Oct 20, 2023

Implements #4795.

mattsse
mattsse requested changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

this makes the primitives crate slightly leaner

crates/reth-tokio-utils/src/lib.rs Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs the usual lib.rs header, see other crates for reference

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #5111 (a08fc5c) into main (fafcabf) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/consensus/beacon/src/engine/mod.rs 73.34% <ø> (ø)
crates/net/network/src/manager.rs 53.52% <ø> (ø)
crates/prune/src/pruner.rs 44.27% <ø> (ø)
crates/stages/src/pipeline/mod.rs 84.05% <ø> (ø)
crates/tokio-util/src/event_listeners.rs 93.33% <ø> (ø)

... and 22 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.08% <ø> (+0.02%) ⬆️
unit-tests 62.17% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.60% <ø> (ø)
trie 94.93% <ø> (-0.04%) ⬇️
txpool 55.33% <ø> (-0.45%) ⬇️
networking 78.16% <ø> (-0.04%) ⬇️
rpc 57.96% <ø> (-0.04%) ⬇️
consensus 63.01% <ø> (ø)
revm 24.54% <ø> (+0.35%) ⬆️
payload builder 7.95% <ø> (ø)
primitives 84.70% <ø> (-0.15%) ⬇️

mattsse
mattsse approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I renamed the crate following repo convention

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-meta Changes in the contributor workflow and planning labels Oct 21, 2023
@mattsse mattsse added this pull request to the merge queue Oct 21, 2023
Merged via the queue into paradigmxyz:main with commit 33df4e5 Oct 21, 2023
24 checks passed
mattsse added a commit that referenced this pull request Nov 8, 2023
@gr4yha7 @mattsse
chore: remove reth primitives [tokio] and [tokio-stream] dependencies (…
42de06d 
…#5111)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-meta Changes in the contributor workflow and planning C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gr4yha7 @mattsse