Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add convenience trait bounds #5131

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 22, 2023

this makes it easier to consume the entire type without using the components individually.

@mattsse mattsse requested a review from onbjerg as a code owner October 22, 2023 16:19
@mattsse mattsse added the C-enhancement New feature or request label Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #5131 (87fa98f) into main (82bffbf) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
bin/reth/src/cli/components.rs 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.07% <ø> (-0.02%) ⬇️
unit-tests 62.14% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.85% <ø> (ø)
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.60% <ø> (ø)
trie 94.96% <ø> (-0.04%) ⬇️
txpool 55.33% <ø> (ø)
networking 78.19% <ø> (-0.11%) ⬇️
rpc 57.80% <ø> (ø)
consensus 63.01% <ø> (ø)
revm 24.47% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 84.70% <ø> (-0.03%) ⬇️

@mattsse mattsse merged commit 0088ba4 into main Oct 22, 2023
23 checks passed
@mattsse mattsse deleted the matt/add-convenience-bounds branch October 22, 2023 16:32
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant