improve calculate_next_block_base_fee
doc
#5135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calculate_next_block_base_fee
function has until now included quite a few formulas and nested logic with little documentation. I thought it might be quite hard to read for a newcomer. So I added several improvements (in my opinion), don't hesitate to tell me if some are not suitable:if / else if / else
into three with documentation each time to understand the logic related to thegas_target
.