Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokio-util): EventListeners with Listener Management #5136

Merged
merged 4 commits into from
Oct 23, 2023
Merged

feat(tokio-util): EventListeners with Listener Management #5136

merged 4 commits into from
Oct 23, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Oct 22, 2023 •
edited
Loading

  • Added functionality to remove specific event listeners
  • Methods for listener count and checking emptiness.

@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Merging #5136 (6935260) into main (55a7871) will decrease coverage by 0.09%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/tokio-util/src/event_listeners.rs 66.66% <0.00%> (-26.67%) ⬇️

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.05% <0.00%> (-0.03%) ⬇️
unit-tests 62.06% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.57% <ø> (-0.29%) ⬇️
blockchain tree 80.82% <ø> (ø)
pipeline 88.36% <ø> (ø)
storage (db) 74.58% <ø> (-0.02%) ⬇️
trie 94.96% <ø> (ø)
txpool 55.31% <ø> (ø)
networking 78.18% <ø> (-0.01%) ⬇️
rpc 57.70% <ø> (-0.12%) ⬇️
consensus 63.01% <ø> (ø)
revm 24.47% <ø> (ø)
payload builder 7.95% <ø> (ø)
primitives 84.70% <ø> (-0.04%) ⬇️

mattsse
mattsse requested changes Oct 23, 2023
View reviewed changes
crates/tokio-util/src/event_listeners.rs Outdated Show resolved Hide resolved
crates/tokio-util/src/event_listeners.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Oct 23, 2023
DoTheBestToGetTheBest and others added 2 commits October 23, 2023 09:46
@DoTheBestToGetTheBest @mattsse
Update crates/tokio-util/src/event_listeners.rs
278fc92 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@DoTheBestToGetTheBest
Update event_listeners.rs
411cb1e
@DoTheBestToGetTheBest
Copy link
Contributor Author

@mattsse hey, all the change you asked has been doing :) Thank you !

@mattsse mattsse enabled auto-merge October 23, 2023 16:52
@mattsse mattsse added this pull request to the merge queue Oct 23, 2023
Merged via the queue into paradigmxyz:main with commit 36dde36 Oct 23, 2023
mattsse added a commit that referenced this pull request Nov 8, 2023
@DoTheBestToGetTheBest @mattsse
feat(tokio-util): EventListeners with Listener Management (#5136)
fc21b64 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoTheBestToGetTheBest @mattsse