Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-testing-util): rpc tracing compare testing support #5148

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

#5146

  • Added function to fetch and compare data with trace_block responses asserting that the results are consistent between both RPC (Reth and another Client).

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #5148 (e7f799b) into main (b71a8ac) will decrease coverage by 50.88%.
Report is 19 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head e7f799b differs from pull request most recent head 634a5c7. Consider uploading reports for the commit 634a5c7 to get more accurate results

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-testing-util/src/trace.rs 0.00% <0.00%> (-26.03%) ⬇️

... and 422 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.05% <0.00%> (-0.02%) ⬇️
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 6.18% <ø> (-24.40%) ⬇️
blockchain tree 0.00% <ø> (-80.83%) ⬇️
pipeline 0.00% <ø> (-88.27%) ⬇️
storage (db) 16.66% <ø> (-57.94%) ⬇️
trie 0.00% <ø> (-94.97%) ⬇️
txpool 32.20% <ø> (-23.12%) ⬇️
networking 28.86% <ø> (-49.36%) ⬇️
rpc 23.76% <0.00%> (-33.95%) ⬇️
consensus 0.88% <ø> (-62.13%) ⬇️
revm 1.33% <ø> (-23.15%) ⬇️
payload builder 7.95% <ø> (ø)
primitives 21.05% <ø> (-63.73%) ⬇️

crates/rpc/rpc-testing-util/src/trace.rs Outdated Show resolved Hide resolved
Comment on lines 167 to 170
pub struct RpcComparer<'a> {
endpoint1: &'a str,
endpoint2: &'a str,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should take two clients, ideally abstracted over jsonrpsee client traits

Copy link
Contributor Author

@DoTheBestToGetTheBest DoTheBestToGetTheBest Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should take two clients, ideally abstracted over jsonrpsee client traits

Change has been made & improved docs

Hope this is good for you boss :)

Thank you for giving me those information ! I never tought it was better with this way !

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not quite perfect, but good enough for the testing we need and can be modified when we have further requirements

@mattsse mattsse added this pull request to the merge queue Nov 6, 2023
Merged via the queue into paradigmxyz:main with commit be542b2 Nov 6, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants