-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc-testing-util): rpc tracing compare testing support #5148
Conversation
Codecov Report
... and 422 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pub struct RpcComparer<'a> { | ||
endpoint1: &'a str, | ||
endpoint2: &'a str, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should take two clients, ideally abstracted over jsonrpsee client traits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should take two clients, ideally abstracted over jsonrpsee client traits
Change has been made & improved docs
Hope this is good for you boss :)
Thank you for giving me those information ! I never tought it was better with this way !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not quite perfect, but good enough for the testing we need and can be modified when we have further requirements
#5146