Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump discv5 #5150

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: bump discv5 #5150

merged 1 commit into from
Oct 23, 2023

Conversation

jgannonjr
Copy link
Contributor

@jgannonjr jgannonjr commented Oct 23, 2023

Bump github.com/sigp/discv5 to the latest version which has updated dependencies as of the latest commit f289bbd4c57d499bb1bdb393af3c249600a1c662.

The previous version depended on ahash = "^0.7.0" which has been yanked from crates.io, as evidenced from running cargo generate-lockfile (see below).

➜  reth git:(main) cargo generate-lockfile
    Updating crates.io index
    Updating git repository `https://github.com/bluealloy/revm`
    Updating git repository `https://github.com/sigp/discv5`
    Updating git repository `https://github.com/stevefan1999-personal/rust-igd`
error: failed to select a version for the requirement `ahash = "^0.7.0"`
candidate versions found which didn't match: 0.8.5, 0.8.4, 0.4.1, ...
location searched: crates.io index
required by package `hashbrown v0.11.0`
    ... which satisfies dependency `hashbrown = "^0.11.0"` of package `hashlink v0.7.0`
    ... which satisfies dependency `hashlink = "^0.7.0"` of package `discv5 v0.3.1 (https://github.com/sigp/discv5?rev=d2e30e04ee62418b9e57278cee907c02b99d5bd1#d2e30e04)`
    ... which satisfies git dependency `discv5` of package `reth-discv4 v0.1.0-alpha.10 (/Users/johnny/code/reth/crates/net/discv4)`
    ... which satisfies path dependency `reth-discv4` of package `manual-p2p v0.0.0 (/Users/johnny/code/reth/examples/manual-p2p)`
perhaps a crate was updated and forgotten to be re-vendored?

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Oct 23, 2023
@mattsse mattsse added this pull request to the merge queue Oct 23, 2023
Merged via the queue into paradigmxyz:main with commit cb8b273 Oct 23, 2023
23 checks passed
mattsse pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants