-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove const generics from cursors and add segment masks #5181
Conversation
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only nits, appreciate the comments. I wonder if there's better way to do that without too much boilerplate, but seems hard without at least rust-lang/rust#29661.
16a0c99
to
48bd002
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
PR into #5170
NippyJarCursor
andSnapshotCursor
.SnapshotCursor
with masks to query and decode values.storage/db/snapshot
into different filesFeels way better/more readable to me. Follow-ups are implementing the rest of
SnapshotJarProvider
providers (after merging the whole PR stack)