Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade debug! to trace! #5186

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 25, 2023

this downgrades logs that can happen regularly and don't have meaningful debug value.

I kept several debugs, mostly related to channel capacity, closing sessions on error

@mattsse mattsse requested a review from Rjected as a code owner October 25, 2023 22:40
@mattsse mattsse added A-observability Related to tracing, metrics, logs and other observability tools A-networking Related to networking in general labels Oct 25, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit f782a33 Oct 26, 2023
22 checks passed
@mattsse mattsse deleted the matt/switch-some-debug-to-trace branch October 26, 2023 09:23
Arindam2407 pushed a commit to Arindam2407/reth that referenced this pull request Oct 31, 2023
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants