Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out empty storage entries in state diff #5230

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: filter out empty storage entries in state diff #5230

merged 1 commit into from
Oct 30, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 30, 2023

we're currently including storage entries like,

however nothing changed here, since value is zero

 "0x000000000000000000000000000000000000000000000000000000000000000b": {
                        "+": "0x0000000000000000000000000000000000000000000000000000000000000000"
                    },

@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Oct 30, 2023
onbjerg
onbjerg approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse enabled auto-merge October 30, 2023 13:35
@mattsse mattsse added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 7140bc2 Oct 30, 2023
@mattsse mattsse deleted the matt/filter-changed-storage-entries branch October 30, 2023 13:46
mattsse added a commit that referenced this pull request Nov 8, 2023
@mattsse
fix: filter out empty storage entries in state diff (#5230)
f095ab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @onbjerg