Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authenticated json rpc endpoint #5250

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Authenticated json rpc endpoint #5250

merged 7 commits into from
Nov 2, 2023

Conversation

1010adigupta
Copy link
Contributor

@1010adigupta 1010adigupta commented Oct 31, 2023 •
edited
Loading

Closes #4919
This pr adds JWT authentication to JSON-RPC endpoint, that is it exposes what's behind JSON-RPC (8545) but under authentication

  • add cli argument for authentication of http/ws
  • add optional JwtSecret field to RpcServerConfig
  • add new variant for auth layer in WsHttpServerKind

mattsse
mattsse requested changes Oct 31, 2023
View reviewed changes
crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-builder/src/lib.rs Show resolved Hide resolved
crates/rpc/rpc-builder/src/lib.rs Show resolved Hide resolved
@mattsse mattsse marked this pull request as ready for review October 31, 2023 17:02
@mattsse mattsse requested a review from Rjected as a code owner October 31, 2023 17:02
@mattsse
Copy link
Collaborator

mattsse commented Nov 2, 2023

@1010adigupta let's wrap this up first

mattsse
mattsse approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'll wire up the CLI next

@mattsse mattsse added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Nov 2, 2023
@mattsse mattsse added this pull request to the merge queue Nov 2, 2023
Merged via the queue into paradigmxyz:main with commit c0e70ba Nov 2, 2023
22 checks passed
@1010adigupta 1010adigupta deleted the Authenticated-JSON-RPC-endpoint branch November 2, 2023 14:30
mattsse added a commit that referenced this pull request Nov 8, 2023
@1010adigupta @mattsse
Authenticated json rpc endpoint (#5250)
d2136f8 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authenticated JSON-RPC endpoint
2 participants
@1010adigupta @mattsse