Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-testing-utils): support test block for trace_call_many #5258

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Oct 31, 2023

Do you agree with these CallRequest data field for these test blocks?

crates/rpc/rpc-testing-util/src/trace.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-testing-util/src/trace.rs Show resolved Hide resolved
@mattsse mattsse added the C-test A change that impacts how or what we test label Oct 31, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@DoTheBestToGetTheBest
Copy link
Contributor Author

Thank you so so much @mattsse

Does it look good for you?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes lgtm champ

@mattsse mattsse added this pull request to the merge queue Oct 31, 2023
Merged via the queue into paradigmxyz:main with commit 40e124b Oct 31, 2023
22 checks passed
mattsse added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants