Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview.json – fix description of "File descriptors" panel #5259

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

crystalbit
Copy link
Contributor

Hey! There is an example grafana dashboard file provided for copying in the book

I used it by myself and found a duplicated description "100% = 1 core" in "File descriptors" panel. (duplicated from "CPU" panel)
This PR proposes to make it empty like in "Memory"

image

So:
fixed description in "File Descriptors" panel - it was mistakenly duplicated from cpu usage

Fixed description in "File Descriptors" panel - it was mistakenly duplicated from cpu usage
@crystalbit crystalbit requested a review from gakonst as a code owner October 31, 2023 22:10
@mattsse mattsse requested a review from shekhirin October 31, 2023 22:13
@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Oct 31, 2023
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@shekhirin shekhirin enabled auto-merge November 1, 2023 15:00
@shekhirin shekhirin added this pull request to the merge queue Nov 1, 2023
Merged via the queue into paradigmxyz:main with commit 4040cd7 Nov 1, 2023
@crystalbit crystalbit deleted the patch-1 branch November 1, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants