fix: trace_filter
matches all transactions on empty addresses
#5279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #4799
The default behavior for
trace_filter
in Erigon when neitherfromAddress
nortoAddress
are specified, is to match and return all transactions in the block range.This PR modifies the
trace_filter
implementation in Reth to match all transactions when neither address filter is specified.This payload returns transactions from Erigon, but an empty array in Reth: (This is a Goerli block)
Response from reth:
Response from Erigon: