Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add nextest config #5320

Merged
merged 1 commit into from
Nov 5, 2023
Merged

chore: add nextest config #5320

merged 1 commit into from
Nov 5, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 5, 2023 •
edited
Loading

Can only be in .config/nextest.toml AFAICT.
Timeouts can only be defined in the config file.
Closes #5306

@DaniPopes DaniPopes requested a review from gakonst as a code owner November 5, 2023 19:52
@DaniPopes DaniPopes requested a review from mattsse November 5, 2023 19:53
@DaniPopes DaniPopes enabled auto-merge November 5, 2023 19:54
mattsse
mattsse approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, 2m should be enough even for all networking tests

@DaniPopes DaniPopes added this pull request to the merge queue Nov 5, 2023
Merged via the queue into main with commit 45628e7 Nov 5, 2023
@DaniPopes DaniPopes deleted the dani/nextest-cfg branch November 5, 2023 20:09
mattsse pushed a commit that referenced this pull request Nov 8, 2023
@DaniPopes @mattsse
chore: add nextest config (#5320)
87182b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test can_peer_with_geth is flaky
2 participants
@DaniPopes @mattsse