-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use helper to deserialize mainnet TTD #5322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, this is now baked into the jsonu256 helper type, but we only need this for genesis, right?
I think we should instead use an annotation there
ah right, yeah, an annotation would be better so we can just do this hack for TTD rather than for everything |
@Rjected test fails in CI for some reason, couldn't reproduce locally in reth-rpc-types |
hmm, I'm only able to repro with nextest run on the entire repo, but at least I can repro |
hmm, apparently it's possible for
Should be able to fix though |
@mattsse we can actually use |
nevermind, that's only for arbitrary precision |
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Followup to #5290, using behavior from gakonst/ethers-rs#2617 instead of find/replace to deserialize the mainnet TTD.