Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): format stage progress with two decimal places #5324

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

shekhirin
Copy link
Collaborator

Otherwise, we show progress at high block numbers as 100%:

stage=Bodies checkpoint=18501436 progress=100.0%

fn main() {
    println!("{:.1}%", 100.0 * 18501436.0 / 18503608.0);
    println!("{:.2}%", 100.0 * 18501436.0 / 18503608.0);
}
100.0%
99.99%

@shekhirin shekhirin added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) A-observability Related to tracing, metrics, logs and other observability tools labels Nov 6, 2023
@shekhirin shekhirin added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 648f54e Nov 6, 2023
25 checks passed
@shekhirin shekhirin deleted the alexey/entities-format-dec-places branch November 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants