Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: serde misc CallRequest #5345

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore: serde misc CallRequest #5345

merged 1 commit into from
Nov 7, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 7, 2023

remove redundant defaults.
skip serialize wif None, reduces data that will be sent, when used client-side

@mattsse mattsse requested a review from Rjected as a code owner November 7, 2023 18:51
@mattsse mattsse added the A-rpc Related to the RPC implementation label Nov 7, 2023
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit fd7896f Nov 7, 2023
25 checks passed
@mattsse mattsse deleted the matt/serde-misc branch November 7, 2023 19:09
mattsse added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants