chore(provider): migrate providers to ProviderError
#5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
the
C-debt
rkrasiuk
changed the title
ProviderError
rkrasiuk
requested review from
joshieDo,
shekhirin,
mattsse,
Rjected,
rakita,
onbjerg and
gakonst
as code owners
DaniPopes
requested changes
Nov 17, 2023
mattsse
requested changes
Nov 17, 2023
| ProviderError::NippyJar(err.to_string()) | ||
| } | ||
| } | ||
|
|
||
| /// Bundled errors variants thrown by various providers. | ||
| #[derive(Clone, Debug, Error, PartialEq, Eq)] | ||
| pub enum ProviderError { |
There was a problem hiding this comment.
since this is the error type for all the provider traits, we should add an Other(box dyn error) variant so additional errors can be used by implementers
There was a problem hiding this comment.
shall we do the String instead? box dyn will require removing PartialEq & Eq which are useful in testing
There was a problem hiding this comment.
I see, let's skip for now, can always change later
mattsse
approved these changes
Nov 17, 2023
DaniPopes
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providers must return a
ProviderError. Otherwise, it is impossible to reuse them in other components without adding a largeRethErrorvariant.The only other error variant that was ever returned by providers was
SenderRecoveryErrorwhich is now added toProviderError