-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bin/args): enhance transactionpool with --txpool.nolocals Flag #5538
feat(bin/args): enhance transactionpool with --txpool.nolocals Flag #5538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty good already.
please be mindful of whether the issue has already been assigned ;)
don't worry, i asked him already if i can take the issue, he was okey with this :) |
just a realy big noob question (and excuse me for this) but cargo check doesn't work in bin/reth, is this normal ? |
for bin try with |
removed the container type |
ty lot for this, solved my problem ty also for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, last doc nits
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
after thinking about this a bit more and also considering the upcoming --locals flag, I think your previous approach with a new wrapper types was better.
I've added this design back real quick
This PR introduces the --txpool.nolocals flag to improve transaction pool behavior by enabling the disabling of local exemptions for locally submitted transactions.
ref #5520